fix: when use c++ 20, compile failed #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muellan Is there any chance that this will be merged upstream? The default C++ version is now 23 and |
antonpaule
reviewed
Sep 13, 2023
include/clipp.h
Outdated
| std::is_same<Ret,typename std::result_of<Fn(Args...)>::type>::value>{} ); | ||
| std::is_same<Ret, | ||
| #if CLIPP_CPLUSPLUS >= 201703L | ||
| typename std::invoke_result<Fn(Args...)>::type |
There was a problem hiding this comment.
Using Apple Clang version 14.0.3 (C++17, C++20), this will not compile.
Shouldn't it be typename std::invoke_result<Fn, Args...> ?
One can also use the shorter version std::invoke_result_t<Fn, Args...>.
|
Any way this PR could be merged any time soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.