-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(ui): Update few links in web UI from 'browse' to '/browse/' #7445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: rampa3 <[email protected]>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mudler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks! I think ultimately we want to use middlewares to handle all of that transparently: https://echo.labstack.com/docs/middleware/trailing-slash
Should I un-draft it? I did not put it in as full PR, as I did not had time to build LocalAI from it today to test. |
yes sure, it looks good here |
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Description
This PR fixes #7443 by updating few link targets from just "browse" to "/browse/", as is seen in source for the new parts of the web UI.
Notes for Reviewers
Creating as a draft for now, have to do testing when not busy with studies.
Signed commits