Skip to content

Conversation

@rampa3
Copy link
Contributor

@rampa3 rampa3 commented Dec 6, 2025

Description

This PR fixes #7443 by updating few link targets from just "browse" to "/browse/", as is seen in source for the new parts of the web UI.

Notes for Reviewers
Creating as a draft for now, have to do testing when not busy with studies.

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Dec 6, 2025

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 49674c2
🔍 Latest deploy log https://app.netlify.com/projects/localai/deploys/6934a2bff5a2f60008d791e0
😎 Deploy Preview https://deploy-preview-7445--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

mudler
mudler previously approved these changes Dec 6, 2025
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks! I think ultimately we want to use middlewares to handle all of that transparently: https://echo.labstack.com/docs/middleware/trailing-slash

@rampa3
Copy link
Contributor Author

rampa3 commented Dec 6, 2025

good catch, thanks! I think ultimately we want to use middlewares to handle all of that transparently: https://echo.labstack.com/docs/middleware/trailing-slash

Should I un-draft it? I did not put it in as full PR, as I did not had time to build LocalAI from it today to test.

@mudler
Copy link
Owner

mudler commented Dec 6, 2025

good catch, thanks! I think ultimately we want to use middlewares to handle all of that transparently: https://echo.labstack.com/docs/middleware/trailing-slash

Should I un-draft it? I did not put it in as full PR, as I did not had time to build LocalAI from it today to test.

yes sure, it looks good here

@rampa3 rampa3 marked this pull request as ready for review December 6, 2025 21:26
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
@mudler mudler merged commit 6aee29d into mudler:master Dec 6, 2025
20 checks passed
@mudler mudler added the bug Something isn't working label Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Acessing model gallery from the installed models page (/manage) or error 404 page yields error 404

2 participants