fix(p2p): parse correctly ExtraLLamaCPPArgs #4220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were sensible when args aren't defined and we would clash parsing extra args. Signed-off-by: Ettore Di Giacinto <[email protected]>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were sensible when args aren't defined and we would clash parsing extra args.
Description
This PR fixes #4214
This pull request includes an important change to the
Runfunction in theworker_p2p.gofile. The change ensures that theextraArgsvariable is properly initialized and adds a debug log statement to provide better visibility into the arguments being used when starting thellama-cpp-rpc-server.Initialization and logging improvements:
core/cli/worker/worker_p2p.go: Modified the initialization of theextraArgsvariable to avoid splitting an empty string and added a debug log statement to log the arguments and their count when starting thellama-cpp-rpc-server.Notes for Reviewers
Signed commits