feat: added support for comparator of null values with equals and notEquals #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huuyafwww
commented
Dec 24, 2024
| export const dateComparators: QueryToComparator<DateQuery> = { | ||
| equals(expected, actual) { | ||
| return compareDates(expected, actual) === 0 | ||
| return compareDates(expected as unknown as Date, actual as unknown as Date) === 0 |
There was a problem hiding this comment.
I added null to equals in DateQuery.
This would cause people to guess that a null value is coming here.
However, since null values cannot be retrieved by getComparatorsForValue, the function for comparison cannot be used.
The null value is now handled before the call.
So the null value will not appear here,
The unknown type is used to overwrite the Date to suppress type errors.
huuyafwww
commented
Dec 24, 2024
Comment on lines
+41
to
+53
| if (comparatorName === "equals" && expectedValue === null) { | ||
| return actualValue === null | ||
| } | ||
|
|
||
| if (comparatorName === "notEquals" && expectedValue === null) { | ||
| return actualValue !== null | ||
| } | ||
|
|
||
| // If an entity doesn't have any value for the property | ||
| // is being queried for, treat it as non-matching. | ||
| if (actualValue == null) { | ||
| return false | ||
| } |
There was a problem hiding this comment.
Fixed control when actualValue is null.
Addes comparison if comparatorName is equals or notEquals and expectedValue is null.
This control prevents null values from entering getComparatorsForValue.
huuyafwww
force-pushed
the
feature/expect_equal_null
branch
from
75f3794 to
da06da0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for developing a great library.
I would like to compare null with equals and notEquals in the Where clause, but it seems that it is not currently supported.
I see the same reported in issue #228.
I wanted this feature and implemented it, what do you think?