fix: overwrite existing cookies #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
reviewed
Apr 29, 2021
kettanaito
reviewed
Apr 29, 2021
kettanaito
reviewed
Apr 29, 2021
kettanaito
requested changes
Apr 29, 2021
There was a problem hiding this comment.
Hey, @chrisguttandin. Happy to review yet another pull request from you! It looks great, I just left a few comments regarding the test's readability. Please let me know if they make sense.
kettanaito
approved these changes
May 4, 2021
There was a problem hiding this comment.
Thank you for shipping this improvement, @chrisguttandin! As always, a pleasure seeing a contribution from you! Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to fix mswjs/msw#708. Apparently the current implementation is filtering expired cookies before adding them to the internal store. This seems to be clever but prevents overwriting existing cookies.