Skip to content

WebGPURenderer: Prevent translation of skybox. #32526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunag merged 2 commits into from
Dec 10, 2025
Merged

WebGPURenderer: Prevent translation of skybox. #32526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab6f3cd
WebGPURenderer: Prevent translation of skybox.
Mugen87 Dec 10, 2025
4acdfab
Update Background.js
Mugen87 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/renderers/common/Background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ class Background extends DataMap {

// compute vertex position
const modifiedPosition = isOrtho.select( positionLocal.mul( orthoScale ), positionLocal );
let viewProj = cameraProjectionMatrix.mul( modelViewMatrix.mul( vec4( modifiedPosition, 1.0 ) ) );

// By using a w component of 0, the skybox will not translate when the camera moves through the scene
let viewProj = cameraProjectionMatrix.mul( modelViewMatrix.mul( vec4( modifiedPosition, 0.0 ) ) );

// force background to far plane so it does not occlude objects
viewProj = viewProj.setZ( viewProj.w );
Expand All @@ -127,12 +129,6 @@ class Background extends DataMap {
backgroundMesh.frustumCulled = false;
backgroundMesh.name = 'Background.mesh';

backgroundMesh.onBeforeRender = function ( renderer, scene, camera ) {

this.matrixWorld.copyPosition( camera.matrixWorld );

};

function onBackgroundDispose() {

background.removeEventListener( 'dispose', onBackgroundDispose );
Expand Down