Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 2, 2025

Related issue: #32249

Description

Third attempt of improving the bind group layout system.

The deletion runtime error has been fixed with this PR and some additional refactoring has been done in WebGPUBindingUtils to simplify things. Hopefully, this should be good now.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 350.43
83.06
350.43
83.06
+0 B
+0 B
WebGPU 614.74
170.7
615.47
170.89
+737 B
+188 B
WebGPU Nodes 613.34
170.44
614.08
170.63
+737 B
+185 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 482.47
117.86
482.47
117.86
+0 B
+0 B
WebGPU 686.07
186.47
686.81
186.65
+737 B
+183 B
WebGPU Nodes 635.91
173.66
636.65
173.84
+737 B
+182 B

@Mugen87 Mugen87 added this to the r182 milestone Dec 2, 2025
@Mugen87 Mugen87 merged commit 1917b3e into mrdoob:dev Dec 2, 2025
10 checks passed
@cmhhelgeson
Copy link
Contributor

@Mugen87 Sorry I couldn't get to this earlier, I've been dealing with some health issues. I assume the issue was solved by just setting bindingsData.layout = undefined, which invalidates the deletion block?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 2, 2025

It was the additional if check:

if ( bindingsData.layout ) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants