PMREMGenerator: Improve GGX VNDF accuracy and match Blender roughness #32311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the accuracy of the GGX VNDF filtering in
PMREMGeneratorto better match standard PBR implementations like Blender by tuning theblurStrengthscalingfactor to 0.0 + targetRoughness * 1.25.Reasoning
We sample from the previous mip level to maintain high performance (~10ms generation time). However, this introduces implicit blur from the downsampling and bilinear interpolation. The adjusted blurStrength factor compensates for this by reducing the applied roughness at lower LODs, preventing the "over-blurring" issue at low roughness values while ensuring the higher roughness levels converge correctly.
The middle column is still too crisp but overall is much better.
Note: Need to find a easier way to make renders with the same camera than the three.js scene 😅