Skip to content

Conversation

@Methuselah96
Copy link
Contributor

Related issue: #31790 (comment)

Description

The error function was sometimes being shadowed by error parameters

@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 356.24
86.48
356.24
86.48
+0 B
-1 B
WebGPU 613.68
172.23
613.68
172.23
+0 B
+0 B
WebGPU Nodes 612.28
171.97
612.28
171.97
+0 B
+1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 488.02
121.25
488.04
121.25
+11 B
-2 B
WebGPU 683.09
187.49
683.1
187.49
+7 B
-2 B
WebGPU Nodes 624.81
170.73
624.82
170.72
+7 B
-1 B

@sunag sunag added this to the r182 milestone Nov 11, 2025
@Mugen87 Mugen87 merged commit 161ed13 into mrdoob:dev Nov 11, 2025
10 checks passed
@Mugen87 Mugen87 changed the title Fix shadowing of error function WebGPURenderer: Fix shadowing of error function. Nov 11, 2025
@Methuselah96 Methuselah96 deleted the fix-catch-err branch November 11, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants