Skip to content

Renderer: Deprecate computeAsync() #32042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunag merged 2 commits into from
Oct 12, 2025
Merged

Renderer: Deprecate computeAsync() #32042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70862a6
use `compute()` instead of `computeAsync()`
sunag Oct 11, 2025
073df9c
deprecated computeAsync()
sunag Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions examples/jsm/gpgpu/BitonicSort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,12 +624,12 @@ export class BitonicSort {
*
* @param {Renderer} renderer - The current scene's renderer.
*/
async computeStep( renderer ) {
computeStep( renderer ) {

// Swap local only runs once
if ( this.currentDispatch === 0 ) {

await renderer.computeAsync( this.swapLocalFn );
renderer.compute( this.swapLocalFn );

this.globalOpsRemaining = 1;
this.globalOpsInSpan = 1;
Expand All @@ -638,7 +638,7 @@ export class BitonicSort {

const swapType = this.globalOpsRemaining === this.globalOpsInSpan ? 'Flip' : 'Disperse';

await renderer.computeAsync( swapType === 'Flip' ? this.flipGlobalNodes[ this.readBufferName ] : this.disperseGlobalNodes[ this.readBufferName ] );
renderer.compute( swapType === 'Flip' ? this.flipGlobalNodes[ this.readBufferName ] : this.disperseGlobalNodes[ this.readBufferName ] );

if ( this.readBufferName === 'Data' ) {

Expand All @@ -655,7 +655,7 @@ export class BitonicSort {
} else {

// Then run local disperses when we've finished all global swaps
await renderer.computeAsync( this.disperseLocalNodes[ this.readBufferName ] );
renderer.compute( this.disperseLocalNodes[ this.readBufferName ] );

const nextSpanGlobalOps = this.globalOpsInSpan + 1;
this.globalOpsInSpan = nextSpanGlobalOps;
Expand All @@ -672,13 +672,13 @@ export class BitonicSort {
// to fulfill the requirement of an in-place sort.
if ( this.readBufferName === 'Temp' ) {

await renderer.computeAsync( this.alignFn );
renderer.compute( this.alignFn );
this.readBufferName = 'Data';

}

// Just reset the algorithm information
await renderer.computeAsync( this.resetFn );
renderer.compute( this.resetFn );

this.currentDispatch = 0;
this.globalOpsRemaining = 0;
Expand All @@ -687,7 +687,7 @@ export class BitonicSort {
} else {

// Otherwise, determine what next swap span is
await renderer.computeAsync( this.setAlgoFn );
renderer.compute( this.setAlgoFn );

}

Expand All @@ -698,15 +698,15 @@ export class BitonicSort {
*
* @param {Renderer} renderer - The current scene's renderer.
*/
async compute( renderer ) {
compute( renderer ) {

this.globalOpsRemaining = 0;
this.globalOpsInSpan = 0;
this.currentDispatch = 0;

for ( let i = 0; i < this.stepCount; i ++ ) {

await this.computeStep( renderer );
this.computeStep( renderer );

}

Expand Down
13 changes: 0 additions & 13 deletions examples/jsm/inspector/Inspector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,19 +68,6 @@ class Inspector extends RendererInspector {

}

computeAsync() {

const renderer = this.getRenderer();
const animationLoop = renderer.getAnimationLoop();

if ( renderer.info.frame > 1 && animationLoop !== null ) {

this.resolveConsoleOnce( 'log', 'TIP: "computeAsync()" was called while a "setAnimationLoop()" is active. This is probably not necessary, use "compute()" instead.' );

}

}

resolveConsoleOnce( type, message ) {

const key = type + message;
Expand Down
4 changes: 2 additions & 2 deletions src/renderers/common/Renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2534,9 +2534,9 @@ class Renderer {
*/
async computeAsync( computeNodes, dispatchSizeOrCount = null ) {

if ( this._initialized === false ) await this.init();
warnOnce( 'Renderer: "computeAsync()" has been deprecated. Use "compute()" and "await renderer.init();" when creating the renderer.' ); // @deprecated r181

this._inspector.computeAsync( computeNodes, dispatchSizeOrCount );
await this.init();

this.compute( computeNodes, dispatchSizeOrCount );

Expand Down