Skip to content

Examples: Update webgpu_lights_spotlight with new interface, and improve GUI parameters compatible #31976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunag merged 4 commits into from
Sep 29, 2025
Merged

Examples: Update webgpu_lights_spotlight with new interface, and improve GUI parameters compatible #31976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37894b0
improve parameters gui
sunag Sep 29, 2025
3f48048
Update webgpu_lights_spotlight.html
sunag Sep 29, 2025
d1bfadd
parse color
sunag Sep 29, 2025
a76a009
Update Values.js
sunag Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions examples/jsm/inspector/ui/Values.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,12 +264,11 @@ class ValueSelect extends Value {
super();

const select = document.createElement( 'select' );
const type = typeof value;

const createOption = ( name, optionValue ) => {

const optionEl = document.createElement( 'option' );
optionEl.value = optionValue;
optionEl.value = name;
optionEl.textContent = name;

if ( optionValue == value ) optionEl.selected = true;
Expand Down Expand Up @@ -300,20 +299,24 @@ class ValueSelect extends Value {

} );

this.options = options;
this.select = select;
this.type = type;

}

getValue() {

const value = this.select.value;
const type = this.type;
const options = this.options;

if ( type === 'number' ) return parseFloat( value );
if ( type === 'boolean' ) return value === 'true';
if ( Array.isArray( options ) ) {

return value;
return options[ this.select.selectedIndex ];

} else {

return options[ this.select.value ];

}

}

Expand Down Expand Up @@ -374,7 +377,15 @@ class ValueColor extends Value {

getValue() {

return this._value;
let value = this._value;

if ( typeof value === 'string' ) {

value = parseInt( value.slice( 1 ), 16 );

}

return value;

}

Expand Down
18 changes: 12 additions & 6 deletions examples/webgpu_lights_spotlight.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,18 @@
<title>three.js webgpu - spotlight</title>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0">
<link type="text/css" rel="stylesheet" href="main.css">
<link type="text/css" rel="stylesheet" href="example.css">
</head>
<body>

<div id="info">
<a href="https://threejs.org" target="_blank" rel="noopener">three.js</a> webgpu - spotlight<br />
<a href="https://threejs.org/" target="_blank" rel="noopener" class="logo-link"></a>

<div class="title-wrapper">
<a href="https://threejs.org/" target="_blank" rel="noopener">three.js</a><span>spot light</span>
</div>

<small>Spot light projecting texture map.</small>
</div>

<script type="importmap">
Expand All @@ -27,7 +33,7 @@

import * as THREE from 'three/webgpu';

import { GUI } from 'three/addons/libs/lil-gui.module.min.js';
import { Inspector } from 'three/addons/inspector/Inspector.js';

import { PLYLoader } from 'three/addons/loaders/PLYLoader.js';
import { OrbitControls } from 'three/addons/controls/OrbitControls.js';
Expand All @@ -48,6 +54,8 @@
renderer.setAnimationLoop( animate );
document.body.appendChild( renderer.domElement );

renderer.inspector = new Inspector();

renderer.toneMapping = THREE.NeutralToneMapping;
renderer.toneMappingExposure = 1;

Expand Down Expand Up @@ -156,7 +164,7 @@

// GUI

const gui = new GUI();
const gui = renderer.inspector.createParameters( 'Settings' );

const params = {
map: textures[ 'disturb.jpg' ],
Expand Down Expand Up @@ -233,8 +241,6 @@

} );

gui.open();

}

function onWindowResize() {
Expand Down
Loading