WebGPURenderer: Fix rendering morphed meshes. #31904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31903.
Description
When two meshes with shared geometry and material share the same node builder state, rendering ends up wrong because the second meshes uses the (referenced) morph target influence values from the first mesh.
Unless this is somehow fixed on the node side by not coupling the uniform buffers directly to a specific mesh,
RenderObjectmust make sure to return different cache keys for such meshes.There was also a bug in
NodeMaterialObserverthat did not update the cached morph target influence values to detect changes which is fixed with this PR as well.