Sampler: Don't set _texture to null.
#31874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31747.
Description
#31497 introduced the private
_textureproperty inSamplerto fix #31480. This property is set tonullif a texture dispose happens.However, a lot of code in context of bind groups breaks if the
textureproperty of a sampler binding isnull. #31747 is one example how runtime errors occur, in this instance during the init of a bind group. However, the same error occurs when the WebGPU backend tries to create bind group layouts. All this code assumesbinding.texturenever points tonull. Even if a texture is disposed, the (cached) binding must point to it for the case the texture is reused again.The cached bindings I'm talking about are the bindings from the render object:
three.js/src/renderers/common/Bindings.js
Line 80 in 47c6359