AsciiEffect: remove noise from black texture #31858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Strange, I don't see these white dots on my computer. Which OS/hardware are you using? |
Contributor
Author
|
The video was recorded on Brave Browser (Chromium) on Windows 🤔 |
Collaborator
|
Is the PR supposed to change the visuals of the effect? When comparing prod and this version, the plane is now rendered with different symbols. Prod: 
Dev: 
|
Contributor
Author
|
Using Math.round, I end up with the same result but no glitch |
Collaborator
|
There is still a minor deviation but I think that's acceptable if the reported glitch is fixed. |
Mugen87
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before, the black background had white dots as we were calling Math.floor() and then using the invert so even a small calculation error 0,0,1 instead of 0,0,0 made a white dot appear in the screen.
Before:
three.js.examples.-.Brave.2025-09-08.11-59-47.mp4
After:
three.js.examples.-.Brave.2025-09-08.12-39-22.mp4