Skip to content

Conversation

@s-rigaud
Copy link
Contributor

@s-rigaud s-rigaud commented Sep 4, 2025

Description

  • CompressedTextureLoader~TexData has a required isCubemap field
  • ProgressiveLightMap._initializeBlurPlane will fail to compile if null is passed and currently an argument is always passed to lightMap param
  • DOMElement is an unknown type, by using HTMLElement or SvgElement we get some autocomplete/linting in IDEs (those support CSS with .style but not Element)
  • KMZLoader.js:133 is caling ColladaLoader.parse without a path argument

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.17
79.12
338.17
79.12
+0 B
+0 B
WebGPU 579.39
160.1
579.39
160.1
+0 B
+0 B
WebGPU Nodes 578
159.86
578
159.86
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.76
113.82
469.76
113.82
+0 B
+0 B
WebGPU 649.09
175.75
649.09
175.75
+0 B
+0 B
WebGPU Nodes 603.2
164.92
603.2
164.92
+0 B
+0 B

@s-rigaud
Copy link
Contributor Author

s-rigaud commented Sep 4, 2025

I also fixed wrong type HTMLDOMElement

@Mugen87 Mugen87 merged commit 1041321 into mrdoob:dev Sep 4, 2025
9 checks passed
@Mugen87 Mugen87 added this to the r181 milestone Sep 4, 2025
@s-rigaud s-rigaud deleted the fix-types branch October 3, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants