Skip to content

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Aug 31, 2025

Fixes #31791

Description

The primitive types of vectors were not being properly converted when used together, as shown in the example in the issue.

@sunag sunag added this to the r181 milestone Aug 31, 2025
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.91
79.11
338.91
79.11
+0 B
+0 B
WebGPU 579.37
159.66
579.4
159.67
+24 B
+1 B
WebGPU Nodes 577.98
159.42
578
159.42
+24 B
+1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 470.78
113.9
470.78
113.9
+0 B
+0 B
WebGPU 649.52
175.53
649.55
175.54
+24 B
+2 B
WebGPU Nodes 603.62
164.68
603.64
164.68
+24 B
+3 B

@sunag sunag modified the milestones: r181, r180 Aug 31, 2025
@sunag sunag marked this pull request as ready for review August 31, 2025 12:50
@sunag sunag merged commit 049e542 into mrdoob:dev Aug 31, 2025
9 checks passed
@sunag sunag deleted the dev-fix-joint-primitive-conversion branch August 31, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TSL: Creating vec* with ivec* results in compilation errors

1 participant