Skip to content

ClippingNode: Move uniforms into render group. #31716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunag merged 1 commit into from
Aug 22, 2025
Merged

ClippingNode: Move uniforms into render group. #31716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/nodes/accessors/ClippingNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { Loop } from '../utils/LoopNode.js';
import { smoothstep } from '../math/MathNode.js';
import { uniformArray } from './UniformArrayNode.js';
import { builtin } from './BuiltinNode.js';
import { renderGroup } from '../core/UniformGroupNode.js';

/**
* This node is used in {@link NodeMaterial} to setup the clipping
Expand Down Expand Up @@ -94,7 +95,7 @@ class ClippingNode extends Node {

if ( this.hardwareClipping === false && numUnionPlanes > 0 ) {

const clippingPlanes = uniformArray( unionPlanes );
const clippingPlanes = uniformArray( unionPlanes ).setGroup( renderGroup );

Loop( numUnionPlanes, ( { i } ) => {

Expand All @@ -113,7 +114,7 @@ class ClippingNode extends Node {

if ( numIntersectionPlanes > 0 ) {

const clippingPlanes = uniformArray( intersectionPlanes );
const clippingPlanes = uniformArray( intersectionPlanes ).setGroup( renderGroup );
const intersectionClipOpacity = float( 1 ).toVar( 'intersectionClipOpacity' );

Loop( numIntersectionPlanes, ( { i } ) => {
Expand Down Expand Up @@ -154,7 +155,7 @@ class ClippingNode extends Node {

if ( this.hardwareClipping === false && numUnionPlanes > 0 ) {

const clippingPlanes = uniformArray( unionPlanes );
const clippingPlanes = uniformArray( unionPlanes ).setGroup( renderGroup );

Loop( numUnionPlanes, ( { i } ) => {

Expand All @@ -169,7 +170,7 @@ class ClippingNode extends Node {

if ( numIntersectionPlanes > 0 ) {

const clippingPlanes = uniformArray( intersectionPlanes );
const clippingPlanes = uniformArray( intersectionPlanes ).setGroup( renderGroup );
const clipped = bool( true ).toVar( 'clipped' );

Loop( numIntersectionPlanes, ( { i } ) => {
Expand Down Expand Up @@ -202,7 +203,7 @@ class ClippingNode extends Node {

return Fn( () => {

const clippingPlanes = uniformArray( unionPlanes );
const clippingPlanes = uniformArray( unionPlanes ).setGroup( renderGroup );
const hw_clip_distances = builtin( builder.getClipDistance() );

Loop( numUnionPlanes, ( { i } ) => {
Expand Down
Loading