ShadowMapViewerGPU: Fix DepthTexture usage #31673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunag
changed the title
Collaborator
Author
Collaborator
|
I am not a fan of that example. I have your changes working on |
Collaborator
Author
Oh yes, this is certainly not the final work. |
Flip the UVs and render with near white, far black.
Collaborator
|
It seems the live example needs to be updated following my commit. But once you are happy, I'd remove this example from the PR. JMHO. |
Mugen87
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29331 (comment)
Description
At the moment we need a base texture that is compatible for initialization. Since
DepthTexturedoes not allow sampling, I usedtextureLoad().In
WebGPURenderer, the beauty pass in the shadow map rendering process is used to color the shadow and individual opacity, as seen inwebgpu_shadowmap_opacity.For this reason, we need to use DepthTexture, which would be the better option anyway.
/cc @WestLangley