TSL: Add roughness as an independent parameter for ssr() and move camera to optional.
#31663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunag
changed the title
roughness as an independent parameter for ssr().roughness as an independent parameter for ssr().
Collaborator
Author
|
I'm thinking about removing the camera as a parameter as well. |
Collaborator
Author
|
I don’t know if you were sharing the sample, I need to check that too. |
Mugen87
approved these changes
Aug 16, 2025
mrdoob
reviewed
Aug 16, 2025
sunag
changed the title
roughness as an independent parameter for ssr().roughness as an independent parameter for ssr() and move camera to optional.
Mugen87
reviewed
Aug 17, 2025
Mugen87
approved these changes
Aug 17, 2025
This was referenced Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #31649
Description
By adding the
roughnessparameter, which defaults tonull, blur will be enabled.This gives more individuality to the inputs, making them improve to modify.