WebGPUBackend: Remove redundant dispose handlers. #31603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Aug 8, 2025
| } | ||
|
|
||
| this.delete( renderTarget ); | ||
| this.backend.delete( renderTarget ); |
There was a problem hiding this comment.
This delete is not necessarily required since the backend data are maintained in a weak map but it's still more correct to remove the data as soon as we can.
Mugen87
commented
Aug 8, 2025
| if ( descriptors === undefined || | ||
| renderTargetData.width !== renderTarget.width || | ||
| renderTargetData.height !== renderTarget.height || | ||
| renderTargetData.dimensions !== renderTarget.dimensions || |
There was a problem hiding this comment.
RenderTarget.dimensions does not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31600.
Description
The PR removes any render target dispose related code from
_getRenderPassDescriptor(). The dispose logic is managed for all backends in Texture.updateRenderTarget(). I assume the code in the WebGPU backend is a leftover from earlier days.