Skip to content

TSL: Improve error message for operators with void values #31593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunag merged 1 commit into from
Aug 7, 2025
Merged

TSL: Improve error message for operators with void values #31593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/nodes/math/OperatorNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,10 @@ class OperatorNode extends TempNode {
* and the input node types.
*
* @param {NodeBuilder} builder - The current node builder.
* @param {?string} [output=null] - The output type.
* @return {string} The node type.
*/
getNodeType( builder ) {
getNodeType( builder, output = null ) {

const op = this.op;

Expand All @@ -117,7 +118,7 @@ class OperatorNode extends TempNode {

if ( typeA === 'void' || typeB === 'void' ) {

return 'void';
return output || 'void';

} else if ( op === '%' ) {

Expand Down Expand Up @@ -193,7 +194,7 @@ class OperatorNode extends TempNode {

const { aNode, bNode } = this;

const type = this.getNodeType( builder );
const type = this.getNodeType( builder, output );

let typeA = null;
let typeB = null;
Expand Down
Loading