Skip to content

Src: Nomenclature clean up #31564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

WestLangley
Copy link
Collaborator

Changed 'reverse' -> 'reversed', plus some subjective changes for clarity

@WestLangley WestLangley added this to the r180 milestone Aug 4, 2025
Copy link

github-actions bot commented Aug 4, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.62
79.03
338.73
79.06
+108 B
+30 B
WebGPU 566.96
156.76
566.96
156.76
+0 B
+0 B
WebGPU Nodes 565.56
156.51
565.56
156.51
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 470.05
113.73
470.15
113.76
+108 B
+31 B
WebGPU 638.44
172.77
638.44
172.77
+0 B
+0 B
WebGPU Nodes 593.09
162.03
593.09
162.03
+0 B
+0 B

@mrdoob
Copy link
Owner

mrdoob commented Aug 4, 2025

Is this easier to read?

USE_LOGARITHMIC_DEPTHBUFFER
USE_REVERSED_DEPTHBUFFER

@WestLangley
Copy link
Collaborator Author

Is this easier to read?

Maybe, but I don't think "depthbuffer" is a word.

@mrdoob
Copy link
Owner

mrdoob commented Aug 4, 2025

Up to you 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants