Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 28, 2025

Fixes #31522

Description

getNodeChildren() ignores private properties on object level but not on the level below. For consistency reasons, private sub properties should also be ignored.

Note: The PR does not fix #31522. However, consistently ignoring private properties makes it possible to workaround the issue, see #31522 (comment).

@github-actions
Copy link

github-actions bot commented Jul 28, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.39
78.91
338.39
78.91
+0 B
+0 B
WebGPU 566.1
156.49
566.16
156.5
+63 B
+10 B
WebGPU Nodes 564.7
156.25
564.77
156.26
+63 B
+11 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.82
113.62
469.82
113.62
+0 B
+0 B
WebGPU 637.32
172.46
637.38
172.47
+63 B
+12 B
WebGPU Nodes 591.96
161.7
592.02
161.71
+63 B
+12 B

@Mugen87 Mugen87 changed the title NoteUtils: Ignore private sub properties in getNodeChildren(). NodeUtils: Ignore private sub properties in getNodeChildren(). Jul 28, 2025
@sunag sunag added this to the r179 milestone Jul 28, 2025
@sunag
Copy link
Collaborator

sunag commented Jul 28, 2025

I added a conditional to check just pure objects.

@sunag sunag merged commit 2155080 into mrdoob:dev Jul 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nodes: getCacheKey() can't handle cyclic references.

2 participants