WebGLShadowMap: Support Reversed Depth #31495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
approved these changes
Jul 25, 2025
mrdoob
reviewed
Jul 28, 2025
| _state.setBlending( NoBlending ); | ||
| _state.buffers.color.setClear( 1, 1, 1, 1 ); | ||
|
|
||
| if ( _state.buffers.depth.getReversed() ) { |
Owner
There was a problem hiding this comment.
Would _state.buffers.depth.isReversed() be better?
Collaborator
Author
Collaborator
There was a problem hiding this comment.
The method is named getReversed() because there is setReversed(). So these methods represent getters and setters for an internal boolean reversed value.
Owner
There was a problem hiding this comment.
Oh, so the check is meant to be:
if ( _state.buffers.depth.getReversed() === true ) {I'll change it, I think it's easier to read that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the proper clear color when using reversed depth.