Skip to content

Matrix4: Rewrite makeOrthographic() for clarity #31451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mugen87 merged 2 commits into from
Jul 21, 2025
Merged

Matrix4: Rewrite makeOrthographic() for clarity #31451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2b370a
Rewrite for clarity
WestLangley Jul 20, 2025
5199f47
Merge branch 'dev' into dev-make_orthographic
WestLangley Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions src/math/Matrix4.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1109,6 +1109,7 @@ class Matrix4 {
makePerspective( left, right, top, bottom, near, far, coordinateSystem = WebGLCoordinateSystem, reversedDepth = false ) {

const te = this.elements;

const x = 2 * near / ( right - left );
const y = 2 * near / ( top - bottom );

Expand Down Expand Up @@ -1168,31 +1169,31 @@ class Matrix4 {
makeOrthographic( left, right, top, bottom, near, far, coordinateSystem = WebGLCoordinateSystem, reversedDepth = false ) {

const te = this.elements;
const w = 1.0 / ( right - left );
const h = 1.0 / ( top - bottom );
const p = 1.0 / ( far - near );

const x = ( right + left ) * w;
const y = ( top + bottom ) * h;
const x = 2 / ( right - left );
const y = 2 / ( top - bottom );

const a = - ( right + left ) / ( right - left );
const b = - ( top + bottom ) / ( top - bottom );

let z, zInv;
let c, d;

if ( reversedDepth ) {

z = - near * p - 1;
zInv = 1 * p;
c = 1 / ( far - near );
d = far / ( far - near );

} else {

if ( coordinateSystem === WebGLCoordinateSystem ) {

z = ( far + near ) * p;
zInv = - 2 * p;
c = - 2 / ( far - near );
d = - ( far + near ) / ( far - near );

} else if ( coordinateSystem === WebGPUCoordinateSystem ) {

z = near * p;
zInv = - 1 * p;
c = - 1 / ( far - near );
d = - near / ( far - near );

} else {

Expand All @@ -1202,9 +1203,9 @@ class Matrix4 {

}

te[ 0 ] = 2 * w; te[ 4 ] = 0; te[ 8 ] = 0; te[ 12 ] = - x;
te[ 1 ] = 0; te[ 5 ] = 2 * h; te[ 9 ] = 0; te[ 13 ] = - y;
te[ 2 ] = 0; te[ 6 ] = 0; te[ 10 ] = zInv; te[ 14 ] = - z;
te[ 0 ] = x; te[ 4 ] = 0; te[ 8 ] = 0; te[ 12 ] = a;
te[ 1 ] = 0; te[ 5 ] = y; te[ 9 ] = 0; te[ 13 ] = b;
te[ 2 ] = 0; te[ 6 ] = 0; te[ 10 ] = c; te[ 14 ] = d;
te[ 3 ] = 0; te[ 7 ] = 0; te[ 11 ] = 0; te[ 15 ] = 1;

return this;
Expand Down