Renderers: Make info log evaluation more robust. #31438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31436.
Description
Previously (see #30400), I have assumed the return value of
getProgramInfoLog()andgetShaderInfoLog()must always be a string. The MDN documents the return values like that.But when looking at the WebGL spec, the return value is defined as
DOMString?. So it can benull. The PR makes sure to make the call ofgetShaderInfoLog()andgetProgramInfoLog()more safe by testing fornull/undefinedand use an empty string in that case. Subsequent code can then work as usual.