Skip to content

Textures: Fix dimensions of video frames. #31425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mugen87 merged 3 commits into from
Jul 15, 2025
Merged

Textures: Fix dimensions of video frames. #31425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7472069
Textures: Fix dimensions of video frames.
Mugen87 Jul 15, 2025
20d5343
Source: Fix `getSize()`.
Mugen87 Jul 15, 2025
370d520
Source: Fix z coordinate for video-like sources.
Mugen87 Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/renderers/common/Textures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,12 @@ class Textures extends DataMap {
target.height = image.videoHeight || 1;
target.depth = 1;

} else if ( image instanceof VideoFrame ) {

target.width = image.displayWidth || 1;
target.height = image.displayHeight || 1;
target.depth = 1;

} else {

target.width = image.width || 1;
Expand Down
12 changes: 11 additions & 1 deletion src/textures/Source.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,23 @@ class Source {

}

/**
* Returns the dimensions of the source into the given target vector.
*
* @param {(Vector2|Vector3)} target - The target object the result is written into.
* @return {(Vector2|Vector3)} The dimensions of the source.
*/
getSize( target ) {

const data = this.data;

if ( data instanceof HTMLVideoElement ) {

target.set( data.videoWidth, data.videoHeight );
target.set( data.videoWidth, data.videoHeight, 0 );

} else if ( data instanceof VideoFrame ) {

target.set( data.displayHeight, data.displayWidth, 0 );

} else if ( data !== null ) {

Expand Down