-
-
Couldn't load subscription status.
- Fork 36.1k
Line2NodeMaterial: Remove unused lineWidth property.
#31401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In the global environment of three.js, the `lineWidth` in `Line2NodeMaterial` does not take effect and is essentially ineffective. To modify the line width, it is necessary to use the `linewidth` setting. Additionally, neither `Material` nor `NodeMaterial` contains a `linewidth` property. Therefore, the `lineWidth` property in `Line2NodeMaterial` should be changed to `linewidth`, and its default value should be set to 1.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Sry. I am unable to fix the ESLint check errors. When I try to modify WebGLRenderer.js, I am prompted that the current file cannot be edited. |
|
Don't worry. The linting errors in |
The property is defined by the Granted, this isn't ideal for documentation since |
delete `linewidth` property.
lineWidth property.
Fixed #31398
Description
In the global environment of three.js, the
lineWidthinLine2NodeMaterialdoes not take effect and is essentially ineffective. To modify the line width, it is necessary to use thelinewidthsetting. Additionally, neitherMaterialnorNodeMaterialcontains alinewidthproperty. Therefore, thelineWidthproperty inLine2NodeMaterialshould be changed tolinewidth, and its default value should be set to 1.