Skip to content

Conversation

@ycw
Copy link
Contributor

@ycw ycw commented Jul 6, 2025

Description

This PR ensures that onUpdate wouldn't be called after dispose().

@github-actions
Copy link

github-actions bot commented Jul 6, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.69
78.76
337.69
78.76
+0 B
+0 B
WebGPU 557.69
154.41
557.69
154.41
+0 B
+0 B
WebGPU Nodes 556.61
154.19
556.61
154.19
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.91
113.45
468.91
113.45
+0 B
+0 B
WebGPU 633.32
171.43
633.32
171.43
+0 B
+0 B
WebGPU Nodes 588.45
160.78
588.45
160.78
+0 B
+0 B

this.generateMipmaps = false;

/**
* The video frame request callback identifier, which is initially zero.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially zero or -1?

@mrdoob mrdoob added this to the r179 milestone Jul 7, 2025
@mrdoob mrdoob merged commit 348c91b into mrdoob:dev Jul 7, 2025
12 checks passed
@ycw ycw deleted the 1 branch July 16, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants