Skip to content

Examples: Improve AA approach in WebGPU water demo. #31354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 2, 2025

Related issue: a9666c6

Description

Unfortunately, enabling MSAA with a MRT setup somewhat kills the performance on mobile. On a Pixel 8a, webgpu_water stutters quite noticeably.

The PR introduces a more lightweight FXAA which produces still good results but without the overhead of multisampling.

https://rawcdn.githack.com/Mugen87/three.js/ce436cda9e1dd19f77172d30dcb502fe03f7492b/examples/webgpu_water.html
Prod for comparison: https://threejs.org/examples/webgpu_water

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 2, 2025

FXAA also produces better results than MSAA when looking flat on the textured surface:

MSAA:

image

FXAA:

image

I understand that MSAA works better in other places but for this particular scene FXAA seems to produce good results with way better performance.

Until traaPass() is compatible with mrt() (see #29842), I recommend to use smaa() or fxaa() for MRT FX setups at the end of the pass chain. At least if the app is supposed to run on mobile devices.

@sunag sunag added this to the r179 milestone Jul 2, 2025
@sunag
Copy link
Collaborator

sunag commented Jul 3, 2025

Until traaPass() is compatible with mrt()

I'll take a look at that...

@Mugen87 Mugen87 merged commit ddeab78 into mrdoob:dev Jul 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants