Skip to content

RoomEnvironment: Set emissiveIntensity instead #31348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mugen87 merged 2 commits into from
Jul 2, 2025
Merged

RoomEnvironment: Set emissiveIntensity instead #31348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a3d5f6
Set emissiveIntensity instead
WestLangley Jul 1, 2025
9d351f5
Update inline comments
WestLangley Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions examples/jsm/environments/RoomEnvironment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {
BoxGeometry,
InstancedMesh,
Mesh,
MeshBasicMaterial,
MeshLambertMaterial,
MeshStandardMaterial,
PointLight,
Scene,
Expand Down Expand Up @@ -168,8 +168,13 @@ class RoomEnvironment extends Scene {

function createAreaLightMaterial( intensity ) {

const material = new MeshBasicMaterial();
material.color.setScalar( intensity );
// create an emissive-only material. see #31348
const material = new MeshLambertMaterial( {
color: 0x000000,
emissive: 0xffffff,
emissiveIntensity: intensity
} );

return material;

}
Expand Down
2 changes: 1 addition & 1 deletion src/materials/MeshBasicMaterial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class MeshBasicMaterial extends Material {
* @type {Color}
* @default (1,1,1)
*/
this.color = new Color( 0xffffff ); // emissive
this.color = new Color( 0xffffff ); // diffuse

/**
* The color map. May optionally include an alpha channel, typically combined
Expand Down