FBXLoader: Gracefully handle missing color data. #31248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Merging. Feel free to reopen #31247 if there are still issues with the asset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31247.
Description
The asset of #31247 has a
LayerElementColordefinition in the FBX asset but without providing the actual color data. According to Blender's FBX importer, there are valid FBX files where this is the case.FBXLoadersimply ignores now the incomplete definition without throwing a runtime error.@trusktr Do you mind testing with below URL if the asset is now displayed as expected?
https://rawcdn.githack.com/mrdoob/three.js/80389de0d4be9c37f4093e1e6e9724577942ef55/editor/index.html