WebGLPrograms: Don't use flat shading with enabled wireframe. #31242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31238.
Description
The PR makes sure that flat shading is only used when
material.wireframe
is disabled.Note that when toggling
material.wireframe
with enabled flat shading, you must setmaterial.needsUpdate
totrue
so the shader gets updated correctly. That is a small compromise since checking thewireframe
property per frame adds additional cost to the renderer and that is potentially not appropriated for this edge case.