LDrawLoader: Don't clear already-loaded materials onload. #31150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Floppy
force-pushed
the
ldraw-materials
branch
3 times, most recently
from
cd86728 to
fefbb4c
Compare
Contributor
Author
|
Tested and working! 
|
Mugen87
reviewed
May 22, 2025
Owner
|
/fyi @gkjohnson |
Contributor
Author
|
Just in case anyone wants to see it in action... https://manyfold.floppy.org.uk/models/5mhxr25tck64/model_files/lnd3c43pl62w |
gkjohnson
reviewed
May 23, 2025
Mugen87
approved these changes
May 23, 2025
gkjohnson
approved these changes
May 23, 2025
Contributor
Author
|
Amazing, thank you all for your reviews and suggestions :) |
Mugen87
changed the title
This was referenced May 31, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* LDraw: don't clear already-loaded materials on load * make addDefaultMaterials an explicit call
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* LDraw: don't clear already-loaded materials on load * make addDefaultMaterials an explicit call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31149
LDraw materials that had been preloaded were being discarded by the load() method. Following suggestions by @Mugen87, this PR:
setMaterialstoaddMaterials, and removes the reset of the material arrays.clearMaterialsto explicitly clear the material arrays.setMaterialswhich calls clear then add, to reproduce the old behaviour and API.