Skip to content

TSL: Fix .toVarying() analyze for optimization #31090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sunag merged 6 commits into from
May 13, 2025
Merged

TSL: Fix .toVarying() analyze for optimization #31090

sunag merged 6 commits into from
May 13, 2025

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented May 12, 2025

@sunag sunag changed the title Dev tsl rev 1 TSL: Improve node system for .toVarying() May 12, 2025
@github-actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.26
78.64		 337.26
78.64		 +0 B
+0 B
WebGPU 548.43
152.04		 549.21
152.28		 +780 B
+241 B
WebGPU Nodes 547.78
151.89		 548.56
152.13		 +780 B
+241 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 467.34
112.95		 467.34
112.95		 +0 B
+0 B
WebGPU 623.35
168.79		 624.12
169.01		 +766 B
+222 B
WebGPU Nodes 578.2
158.07		 578.97
158.31		 +766 B
+232 B

@sunag sunag changed the title TSL: Improve node system for .toVarying() TSL: Fix .toVarying() and analyze for optimization May 12, 2025
@sunag sunag changed the title TSL: Fix .toVarying() and analyze for optimization TSL: Fix .toVarying() analyze for optimization May 12, 2025
@sunag sunag marked this pull request as ready for review May 12, 2025 18:01
@sunag sunag added this to the r177 milestone May 12, 2025
@sunag sunag merged commit c35b177 into mrdoob:dev May 13, 2025
12 checks passed
@sunag sunag deleted the dev-tsl-rev-1 branch May 13, 2025 19:51
@sunag sunag mentioned this pull request May 13, 2025
Closed
This was referenced May 24, 2025
Merged
Closed
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@sunag @RuthySheffi
TSL: Fix .toVarying() analyze for optimization (mrdoob#31090)
5400bed 
* fix cache of varying inside a conditional of fragment stage

* add `isAssignNode`

* improve optimization system for varyings

* cleanup

* second approach

* Update StackNode.js
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@sunag @RuthySheffi
TSL: Fix .toVarying() analyze for optimization (mrdoob#31090)
e190a41 
* fix cache of varying inside a conditional of fragment stage

* add `isAssignNode`

* improve optimization system for varyings

* cleanup

* second approach

* Update StackNode.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r177

Development

Successfully merging this pull request may close these issues.

TSL: error redeclaration of 'nodeConst1'

1 participant

@sunag