Revert "Examples: Add textured assets to webgl_loader_fbx."
#31067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a1224db.
Contributor
|
Sorry to late reply. |
tatsuya-ogawa
added a commit
to tatsuya-ogawa/three.js
that referenced
this pull request
May 15, 2025
…rdoob#31057)" (mrdoob#31067)" This reverts commit 8c66673.
Mugen87
pushed a commit
that referenced
this pull request
May 15, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
…31057)" (mrdoob#31067) This reverts commit a1224db.
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
…ob#31117) * Revert "Revert "Examples: Add textured assets to `webgl_loader_fbx`. (mrdoob#31057)" (mrdoob#31067)" This reverts commit 8c66673. * update model to clean mesh
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
…31057)" (mrdoob#31067) This reverts commit a1224db.
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
…ob#31117) * Revert "Revert "Examples: Add textured assets to `webgl_loader_fbx`. (mrdoob#31057)" (mrdoob#31067)" This reverts commit 8c66673. * update model to clean mesh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #31057
@tatsuya-ogawa I had to revert the PR because the new assets do not just hold a mesh but also a perspective camera and point light. I suspect you have created these in Blender and simply exported everything, not just the mesh. Since the point light will end up as a shadow casting light, this affects the renderer's memory.
Please file a new PR with clean assets.