PCDLoader: Implement data type dependent binary parsing. #31061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Do you mind sharing a PCD file that can't be loaded with the current implementation? In this way, we have a test asset so it's possible to verify your changes. |
Mugen87
reviewed
May 8, 2025
Contributor
Author
|
@Mugen87 I don't have a suitable pcd file for public use, but I can convert the previous Zaghetto to 8bit to verify it. What do you think?
|
Collaborator
|
That sounds good. However, I would not replace the existing asset. Just add an additional 8-bit version |
Mugen87
reviewed
May 8, 2025
Contributor
Author
|
@Mugen87 Yes, as you expected, I kept the original files. |
Contributor
Author
|
And a file switching option is added to the example.
|
Mugen87
reviewed
May 8, 2025
Mugen87
approved these changes
May 8, 2025
Mugen87
changed the title
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* feat: implement binary PCD data type parsing * chore: code format * chore: add verification file * chore: add file select widget * fix: destroy gui
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* feat: implement binary PCD data type parsing * chore: code format * chore: add verification file * chore: add file select widget * fix: destroy gui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Unable to properly parse the 8-bit size of the pcd coordinate information.
Description
Obtain the data type of the FIELDS field by combining SIZE and TYPE.