Skip to content

TextureLoader inherits FbxLoader's credentials #31031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tatsuya-ogawa wants to merge 1 commit into from
Closed

TextureLoader inherits FbxLoader's credentials #31031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/jsm/loaders/FBXLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ class FBXLoader extends Loader {
}

// console.log( fbxTree );

const textureLoader = new TextureLoader( this.manager ).setPath( this.resourcePath || path ).setCrossOrigin( this.crossOrigin );
const scope = this;
const textureLoader = new TextureLoader( this.manager ).setPath( this.resourcePath || path ).setCrossOrigin( this.crossOrigin ).setRequestHeader( scope.requestHeader ).setWithCredentials( scope.withCredentials );
Copy link
Collaborator

@Mugen87 Mugen87 Apr 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has no effect since TextureLoader internally uses ImageLoader and this loader does not use Loader.requestHeader and Loader.withCredentials. These properties are mainly relevant for FileLoader.

Copy link
Contributor Author

@tatsuya-ogawa tatsuya-ogawa Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mugen87 Thank you.
I’d like to use FBXLoader with a closed site that requires authentication, so I want to replace the TextureLoader with one that supports authentication.
Would it be acceptable to add such a mechanism?

Copy link
Contributor Author

@tatsuya-ogawa tatsuya-ogawa Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#31032


return new FBXTreeParser( textureLoader, this.manager ).parse( fbxTree );

Expand Down