Skip to content

SpotLightNode: Add custom attenuation using spotLight.attenuationNode #31013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sunag merged 2 commits into from
Apr 28, 2025
Merged

SpotLightNode: Add custom attenuation using spotLight.attenuationNode #31013

sunag merged 2 commits into from
Apr 28, 2025

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Apr 28, 2025

Closes #30993 (comment)

Description

Add custom attenuation using spotLight.attenuationNode.

image

@sunag sunag added this to the r177 milestone Apr 28, 2025
@github-actions
Copy link

github-actions bot commented Apr 28, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.33
78.33		 336.33
78.33		 +0 B
+0 B
WebGPU 547.56
151.81		 547.81
151.88		 +251 B
+70 B
WebGPU Nodes 546.91
151.66		 547.16
151.73		 +251 B
+70 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.78
112.28		 465.78
112.28		 +0 B
+0 B
WebGPU 622.41
168.39		 622.66
168.44		 +251 B
+53 B
WebGPU Nodes 577.29
157.65		 577.54
157.71		 +251 B
+65 B

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 28, 2025
View reviewed changes
@sunag sunag marked this pull request as ready for review April 28, 2025 03:28
@sunag sunag merged commit 5ab06a3 into mrdoob:dev Apr 28, 2025
12 checks passed
@sunag sunag deleted the dev-attenuationnode branch April 28, 2025 03:30
@WestLangley
Copy link
Collaborator

WestLangley commented Apr 28, 2025

@Mugen87

  1. I don't think this PR accommodates the aspect ratio of the texture as in the original feature request. Do you agree?

  2. Do you also see the intensity as relatively brighter on the diagonals in this implementation?

@sunag sunag mentioned this pull request Apr 28, 2025
Merged
3 tasks
This was referenced May 20, 2025
Merged
Closed
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@sunag @RuthySheffi
SpotLightNode: Add custom attenuation using `spotLight.attenuationNod…
04e613a 
…e` (mrdoob#31013)

* add custom attenuation

* cleanup
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@sunag @RuthySheffi
SpotLightNode: Add custom attenuation using `spotLight.attenuationNod…
9e9a8b7 
…e` (mrdoob#31013)

* add custom attenuation

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r177

Development

Successfully merging this pull request may close these issues.

Spotlights Use Rectangular Projection

2 participants

@sunag @WestLangley