Skip to content

TSL: Cache getShadowRenderObjectFunction() #30969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunag merged 1 commit into from
Apr 20, 2025
Merged

TSL: Cache getShadowRenderObjectFunction() #30969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 34 additions & 9 deletions src/nodes/lighting/ShadowNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ import { lightShadowMatrix } from '../accessors/Lights.js';
import { resetRendererAndSceneState, restoreRendererAndSceneState } from '../../renderers/common/RendererUtils.js';
import { getDataFromObject } from '../core/NodeUtils.js';
import { getShadowMaterial, BasicShadowFilter, PCFShadowFilter, PCFSoftShadowFilter, VSMShadowFilter } from './ShadowFilterNode.js';
import ChainMap from '../../renderers/common/ChainMap.js';

//

const _shadowRenderObjectLibrary = /*@__PURE__*/ new ChainMap();
const _shadowRenderObjectKeys = [];

/**
* Creates a function to render shadow objects in a scene.
Expand All @@ -38,25 +44,44 @@ import { getShadowMaterial, BasicShadowFilter, PCFShadowFilter, PCFSoftShadowFil
*/
export const getShadowRenderObjectFunction = ( renderer, shadow, shadowType, useVelocity ) => {

return ( object, scene, _camera, geometry, material, group, ...params ) => {
_shadowRenderObjectKeys[ 0 ] = renderer;
_shadowRenderObjectKeys[ 1 ] = shadow;

let renderObjectFunction = _shadowRenderObjectLibrary.get( _shadowRenderObjectKeys );

if ( renderObjectFunction === undefined || ( renderObjectFunction.shadowType !== shadowType || renderObjectFunction.useVelocity !== useVelocity ) ) {

renderObjectFunction = ( object, scene, _camera, geometry, material, group, ...params ) => {

if ( object.castShadow === true || ( object.receiveShadow && shadowType === VSMShadowMap ) ) {

if ( object.castShadow === true || ( object.receiveShadow && shadowType === VSMShadowMap ) ) {
if ( useVelocity ) {

if ( useVelocity ) {
getDataFromObject( object ).useVelocity = true;

getDataFromObject( object ).useVelocity = true;
}

object.onBeforeShadow( renderer, object, _camera, shadow.camera, geometry, scene.overrideMaterial, group );

renderer.renderObject( object, scene, _camera, geometry, material, group, ...params );

object.onAfterShadow( renderer, object, _camera, shadow.camera, geometry, scene.overrideMaterial, group );

}

object.onBeforeShadow( renderer, object, _camera, shadow.camera, geometry, scene.overrideMaterial, group );
};

renderer.renderObject( object, scene, _camera, geometry, material, group, ...params );
renderObjectFunction.shadowType = shadowType;
renderObjectFunction.useVelocity = useVelocity;

object.onAfterShadow( renderer, object, _camera, shadow.camera, geometry, scene.overrideMaterial, group );
_shadowRenderObjectLibrary.set( _shadowRenderObjectKeys, renderObjectFunction );

}
}

_shadowRenderObjectKeys[ 0 ] = null;
_shadowRenderObjectKeys[ 1 ] = null;

};
return renderObjectFunction;

};

Expand Down