Skip to content

LightsNode: Honor spotlight maps in cache key. #30940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mugen87 merged 2 commits into from
Apr 18, 2025
Merged

LightsNode: Honor spotlight maps in cache key. #30940

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c11d25
LightsNode: Honor spotlight maps in cache key.
Mugen87 Apr 16, 2025
9b7a4bf
LightsNode: Make spot light hash more robust.
Mugen87 Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/nodes/lighting/LightsNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,23 +107,33 @@ class LightsNode extends Node {
}

/**
* Overwrites the default {@link Node#customCacheKey} implementation by including the
* light IDs into the cache key.
* Overwrites the default {@link Node#customCacheKey} implementation by including
* light data into the cache key.
*
* @return {number} The custom cache key.
*/
customCacheKey() {

const lightIDs = [];
const hashData = [];
const lights = this._lights;

for ( let i = 0; i < lights.length; i ++ ) {

lightIDs.push( lights[ i ].id );
const light = lights[ i ];

hashData.push( light.id );

if ( light.isSpotLight === true ) {

const hashValue = ( light.map !== null ) ? light.map.id : - 1;

hashData.push( hashValue );

}

}

return hashArray( lightIDs );
return hashArray( hashData );

}

Expand Down