Skip to content

Core: Remove Luminance and LuminanceAlpha format #30934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mugen87 merged 3 commits into from
Apr 15, 2025
Merged

Core: Remove Luminance and LuminanceAlpha format #30934

Mugen87 merged 3 commits into from
Apr 15, 2025

Conversation

@gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Apr 15, 2025 •
edited by Mugen87
Loading

Fixed #30928

Description

Removes all references to Luminance and LuminanceAlpha format which have apparently not worked for over 3 years 😅

@gkjohnson gkjohnson added this to the r176 milestone Apr 15, 2025
@gkjohnson gkjohnson mentioned this pull request Apr 15, 2025
Closed
@github-actions
Copy link

github-actions bot commented Apr 15, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.49
78.38		 336.33
78.33		 -162 B
-47 B
WebGPU 544.68
150.82		 544.52
150.73		 -162 B
-85 B
WebGPU Nodes 544.03
150.66		 543.87
150.58		 -162 B
-84 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.58
112.26		 465.48
112.23		 -101 B
-30 B
WebGPU 618.38
167.07		 618.31
167.05		 -68 B
-21 B
WebGPU Nodes 573.25
156.44		 573.18
156.42		 -68 B
-22 B

@Mugen87 Mugen87 merged commit f6f0183 into mrdoob:dev Apr 15, 2025
12 checks passed
@CodyJasonBennett CodyJasonBennett mentioned this pull request Apr 23, 2025
Merged
This was referenced Apr 23, 2025
Merged
Closed
@haxiomic haxiomic mentioned this pull request Apr 26, 2025
Closed
@gkjohnson gkjohnson deleted the remove-luminance branch April 29, 2025 16:31
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@gkjohnson @RuthySheffi
Core: Remove Luminance and LuminanceAlpha format (mrdoob#30934)
a62c272 
* Remove luminance from docs.

* Remove Luminance constants

* Update editor lines to remove Luminance references
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@gkjohnson @RuthySheffi
Core: Remove Luminance and LuminanceAlpha format (mrdoob#30934)
c21ff4e 
* Remove luminance from docs.

* Remove Luminance constants

* Update editor lines to remove Luminance references
@ospira ospira mentioned this pull request Jul 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r176

Development

Successfully merging this pull request may close these issues.

WebGLRenderer: LuminanceFormat does not seem to work

2 participants

@gkjohnson @Mugen87