Skip to content

TSL: Fix and improve bvec operators #30922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 16, 2025
Merged

TSL: Fix and improve bvec operators #30922

merged 5 commits into from
Apr 16, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Apr 13, 2025

Closes #30897

Description

Fix and improve bvec operators

@sunag sunag changed the title Fix and improve bvec operators TSL: Fix and improve bvec operators Apr 13, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 13, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.49
78.38		 336.49
78.38		 +0 B
+0 B
WebGPU 542.52
150.29		 542.2
150.33		 -314 B
+40 B
WebGPU Nodes 541.87
150.13		 541.55
150.17		 -314 B
+39 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.45
112.23		 465.45
112.23		 +0 B
+0 B
WebGPU 615.32
166.3		 615
166.31		 -314 B
+12 B
WebGPU Nodes 570.19
155.68		 569.88
155.69		 -314 B
+8 B

@sunag sunag added this to the r176 milestone Apr 16, 2025
@sunag sunag marked this pull request as ready for review April 16, 2025 03:13
@sunag sunag merged commit ecd120d into mrdoob:dev Apr 16, 2025
12 checks passed
@sunag sunag deleted the dev-op branch April 16, 2025 03:40
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@sunag @RuthySheffi
TSL: Fix and improve bvec operators (mrdoob#30922)
c652cbf 
* fix bvec operators

* Update OperatorNode.js

* revision

* rev

* rev
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@sunag @RuthySheffi
TSL: Fix and improve bvec operators (mrdoob#30922)
85376d3 
* fix bvec operators

* Update OperatorNode.js

* revision

* rev

* rev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r176
Development

Successfully merging this pull request may close these issues.

TSL .greaterThan maps directly to the GLSL > operator
1 participant
@sunag