RenderTarget: Fix depth texture assignment regression. #30921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture assignment in the RenderTarget constructor. Now using the setter function again like in r174 and before to ensure renderTarget is properly linked to the texture
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
approved these changes
Apr 13, 2025
Collaborator
|
Good catch! |
Mugen87
changed the title
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
…ture assignment in the RenderTarget constructor. Now using the setter function again like in r174 and before to ensure renderTarget is properly linked to the texture (mrdoob#30921) Co-authored-by: Attila Schroeder <[email protected]>
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
…ture assignment in the RenderTarget constructor. Now using the setter function again like in r174 and before to ensure renderTarget is properly linked to the texture (mrdoob#30921) Co-authored-by: Attila Schroeder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a small bug in RenderTarget.js. I corrected the usage of depthTexture assignment in the RenderTarget constructor. Now using the setter function again like in r174 and before. The setter ensure the correct _depthTexture assignment and proper renderTarget linkage.
Fixed #30895
A lot of changes were made in #30633, and this may have gotten lost