Skip to content

XRManager: Request reference space for both layers and non layers. #30902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

XRManager: Request reference space for both layers and non layers. #30902

merged 2 commits into from
Apr 11, 2025

Conversation

danrossi
Copy link
Contributor

@danrossi danrossi commented Apr 10, 2025

Fixed #30901

Description

When using the WebGPURenderer and forcing WebGL for WebXR. XRManager isn't setting up the reference space for non layers.

Copy link

github-actions bot commented Apr 10, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.49
78.38
336.49
78.38
+0 B
+0 B
WebGPU 542.05
150.13
542.05
150.13
+0 B
-1 B
WebGPU Nodes 541.51
150.03
541.51
150.03
+0 B
-1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.42
112.22
465.42
112.22
+0 B
+0 B
WebGPU 614.89
166.17
614.89
166.17
+0 B
+0 B
WebGPU Nodes 569.88
155.58
569.88
155.58
+0 B
-1 B

@Mugen87 Mugen87 changed the title request reference space for both layers and non layers XRManager: Request reference space for both layers and non layers. Apr 10, 2025
@Mugen87 Mugen87 added this to the r176 milestone Apr 10, 2025
Copy link
Contributor Author

@danrossi danrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.

@Mugen87 Mugen87 merged commit 52004ec into mrdoob:dev Apr 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XRManager doesn't setup reference space for non layers.
2 participants