Skip to content

TSL: Fix optional Fn parameters #30884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

TSL: Fix optional Fn parameters #30884

merged 1 commit into from
Apr 7, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Apr 7, 2025

Fixes #30876

Description

This PR fixed the function call when all function parameters are optional, thus enabling the possibility of calling this function without parameters as described in the fixed issue for example.

@sunag sunag added this to the r176 milestone Apr 7, 2025
@sunag sunag marked this pull request as ready for review April 7, 2025 04:42
Copy link

github-actions bot commented Apr 7, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.49
78.38
336.49
78.38
+0 B
+0 B
WebGPU 542.03
150.13
542.05
150.14
+22 B
+5 B
WebGPU Nodes 541.5
150.03
541.52
150.03
+22 B
+6 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.42
112.22
465.42
112.22
+0 B
+0 B
WebGPU 614.87
166.18
614.9
166.18
+22 B
+5 B
WebGPU Nodes 569.86
155.58
569.88
155.59
+22 B
+6 B

@sunag sunag merged commit e6f3101 into mrdoob:dev Apr 7, 2025
12 checks passed
@sunag sunag deleted the dev-fix-params branch April 7, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSL: check() param coord default value does not work.
1 participant