Skip to content

WebGPURenderer: Make material.transparent behave as in WebGLRenderer #30862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunag merged 2 commits into from
Apr 8, 2025
Merged

WebGPURenderer: Make material.transparent behave as in WebGLRenderer #30862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c5d852
WebGPU: Make material.transparent behave as in WebGL
rkreis-v Apr 4, 2025
357b052
cleanup
sunag Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/renderers/webgpu/utils/WebGPUPipelineUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class WebGPUPipelineUtils {

let blending;

if ( material.transparent === true && material.blending !== NoBlending ) {
if ( material.blending !== NoBlending && ( material.blending !== NormalBlending || material.transparent === true ) ) {
Copy link
Collaborator

@WestLangley WestLangley Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkreis-v @sunag @Mugen87

As I mentioned in the discussion, to replicate the WebGLRenderer logic exactly, I think it should be:

if ( material.blending !== NoBlending && ( material.blending !== NormalBlending || material.transparent !== false ) ) {

Copy link
Collaborator

@Mugen87 Mugen87 Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated: 4e3db42


blending = this._getBlending( material );

Expand Down