Skip to content

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Mar 31, 2025

Related issue: #30797

Description

Show shader stage in debug() message.

@sunag sunag requested a review from Copilot March 31, 2025 16:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the debug output by including the shader stage information in the debug message.

  • Introduces a new title incorporating the shader stage.
  • Generates a dynamic border that matches the title’s length.

@sunag sunag added this to the r176 milestone Mar 31, 2025
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.36
78.34
336.36
78.34
+0 B
+0 B
WebGPU 532.9
148.08
532.94
148.11
+48 B
+29 B
WebGPU Nodes 532.36
147.98
532.41
148
+48 B
+29 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.37
112.21
465.37
112.21
+0 B
+0 B
WebGPU 604.53
164.05
604.58
164.08
+48 B
+29 B
WebGPU Nodes 559.52
153.5
559.57
153.53
+48 B
+29 B

@sunag sunag marked this pull request as ready for review April 1, 2025 03:52
@sunag sunag merged commit d3ca4be into mrdoob:dev Apr 1, 2025
12 checks passed
@sunag sunag deleted the dev-debug-message branch April 1, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant