Skip to content

Attributes: Fix null check. #30694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Attributes: Fix null check. #30694

merged 1 commit into from
Mar 9, 2025

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 9, 2025

Fixed #30693.

Description

The statement const attributeData = super.delete( attribute ); does never return undefined. So checking for it has no effect. null must be used instead.

This is a regression which was unfortunately introduced in #30188 when the return type of DataMap.delete() was changed.

Copy link

github-actions bot commented Mar 9, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.02
78.26
336.02
78.26
+0 B
+0 B
WebGPU 523.98
145.48
523.98
145.48
-2 B
+0 B
WebGPU Nodes 523.45
145.37
523.44
145.38
-2 B
+1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.06
112.14
465.06
112.14
+0 B
+0 B
WebGPU 594.38
161.07
594.38
161.07
-2 B
-2 B
WebGPU Nodes 549.51
150.51
549.5
150.51
-2 B
+0 B

@Mugen87 Mugen87 added this to the r175 milestone Mar 9, 2025
@Mugen87 Mugen87 merged commit f760c50 into mrdoob:dev Mar 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PointLightHelper can't dispose when use WebGPURenderer
1 participant