WebGLRenderer: Fixed readRenderTargetPixelsAsync checking readability against incorrect render target #30672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… against incorrect render target readRenderTargetPixelsAsync was checking if the render target was readable before binding the render target to active framebuffer. This resulted in the texture readability check occurring on the previously set framebuffer and not the render target we are reading pixels from.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
|
Thanks - the docs don't make it completely clear that the two gl enumerations are dependent on a bound framebuffer. Greggman's writeup on readpixels confirms it.
Looking at the diff without whitespace changes makes it easier to read. Add |
gkjohnson
reviewed
Mar 7, 2025
gkjohnson
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
readRenderTargetPixelsAsync was checking if the render target was readable before binding the render target to active framebuffer.
This resulted in the texture readability check occurring on the previously set framebuffer and not the render target we are reading pixels from.
I modified the webgl_interactive_cubes_gpu example to restore the render target to the default before we call readRenderTargetPixelsAsync as that reproduces the issue without the fix.
EDIT: For some reason the file diff looks disgusting, please refer to the "Commits" tab instead of "Files changed" for better clarity on what changed.